Messages in this thread Patch in this message | | | Date | Wed, 15 Aug 2012 10:12:46 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [perf] make clean problematic bashism |
| |
Em Wed, Aug 15, 2012 at 12:26:48PM +0200, Peter Zijlstra escreveu: > On Wed, 2012-08-15 at 11:52 +0200, Wouter M. Koolen wrote: > > The reason for this was a bunch of generated empty flex files in util/ > > that were not removed by make clean. They are intended to be erased, > > since the Makefile executes
> > rm -f util/*-{bison,flex}*
> > however, this command does not remove the files. I guess because {,} > > alternatives are only special in bash but the makefile is run with some > > other shell?
> ISTR us getting a number of such patches, did we miss a site, acme?
[acme@sandy linux]$ git describe --match 'v[0-9].[0-9]*' 7f309ed6453926a81e2a97d274f67f1e48f0d74c v3.5-358-g7f309ed [acme@sandy linux]$ git show --oneline 7f309ed6453926a81e2a97d274f67f1e48f0d74c 7f309ed perf tools: Remove brace expansion from clean target diff --git a/tools/perf/Makefile b/tools/perf/Makefile index 32912af..35655c3 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile @@ -987,7 +987,8 @@ clean: $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo $(OUTPUT)common-cmds.h TAGS tags cscope* $(MAKE) -C Documentation/ clean $(RM) $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)PERF-CFLAGS - $(RM) $(OUTPUT)util/*-{bison,flex}* + $(RM) $(OUTPUT)util/*-bison* + $(RM) $(OUTPUT)util/*-flex* $(python-clean) .PHONY: all install clean strip $(LIBTRACEEVENT) [acme@sandy linux]$ > > I got perf to compile now, but thought you would be interested to know > > about this little problem.
> > PS: as a side note: GNU make has the .DELETE_ON_ERROR: special target, > > which removes the target file when its generating command fails. This > > would have prevented my problem and sounds like a good idea in general. > > Maybe perf could make use of this feature when on GNU make?
> I don't think we build with anything but gnu make, mind sending a patch > implementing your suggestion?
Yeah, please submit a patch,
- Arnaldo
| |