[lkml]   [2012]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 01/16] hashtable: introduce a small and naive hashtable

(Sasha, would it be possible to change your MUA so that it breaks long
lines. It's pretty difficult to reply to.)

On Wed, Aug 15, 2012 at 02:24:49AM +0200, Sasha Levin wrote:
> The hashtable uses hlist. hlist provides us with an entire family of
> init functions which I'm supposed to use to initialize hlist heads.
> So while a memset(0) will work perfectly here, I consider that
> cheating - it results in an uglier code that assumes to know about
> hlist internals, and will probably break as soon as someone tries to
> do something to hlist.

I think we should stick with INIT_HLIST_HEAD(). It's not a hot path
and we might add, say, debug fields or initialization magics added
later. If this really matters, the right thing to do would be adding
something like INIT_HLIST_HEAD_ARRAY().



 \ /
  Last update: 2012-08-15 03:22    [W:0.040 / U:12.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site