lkml.org 
[lkml]   [2012]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 03/31] arm64: Exception handling
    Hi,

    This one is a bit denser, so just a quick first pass with a couple of minor
    comments. I'll revisit the rest.

    On Tue, Aug 14, 2012 at 06:52:04PM +0100, Catalin Marinas wrote:

    > +el1_sp_pc:
    > + /*
    > + *Stack or PC alignment exception handling
    > + */
    > + mrs x0, far_el1
    > + mov x1, x25
    > + mov x2, sp
    > + b do_sp_pc_abort
    > +el1_undef:
    > + /*
    > + *Undefined instruction
    > + */

    Nit: Missing spaces in the comment here and the one above.

    > +el0_undef:
    > + /*
    > + *Undefined instruction
    > + */
    > + mov x0, sp
    > + b do_undefinstr

    Here too.

    > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
    > new file mode 100644
    > index 0000000..8712a8e
    > --- /dev/null
    > +++ b/arch/arm64/kernel/traps.c
    [...]
    > +DEFINE_SPINLOCK(die_lock);

    Should probably be static.



    \
     
     \ /
      Last update: 2012-08-15 02:22    [W:4.164 / U:1.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site