lkml.org 
[lkml]   [2012]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 02/19] Input: Improve the events-per-packet estimate
Hi Ping,

Long time no see. :-)

> > + /* Make room for KEY and MSC events */
> > + events += 7;
>
> It is nice to get rid of the redundant pieces and to incorporate
> common functions. Thank you.
>
> I have a question about the code above though. Why do we use 7
> instead of going through the keys like:
>
> for (i = 0; i < KEY_MAX; i++)
> if (test_bit(i, dev->keybit))
> events++;

Keyboards register a large amount of different keys, but seldom send
more than one or two at a time. The value 7 is ad hoc, admittedly, but
it makes the default buffer 8 bytes, which happens to precisely match
the default buffer in evdev.

Thanks,
Henrik


\
 
 \ /
  Last update: 2012-08-14 22:44    [W:0.094 / U:23.548 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site