lkml.org 
[lkml]   [2012]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] perf: teach perf inject to merge sched_stat_* and sched_switch events

* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:

> static int process_sample_event(struct perf_tool *tool __used,
> union perf_event *event,
> struct perf_sample *sample,
> struct perf_evsel *evsel,
> struct machine *machine)

Just saw this 5-parameter function signature fly by: as a
separate clean-up it would be really neat to stick most of these
into an intuitively named helper structure or so.

struct event_context ectx?

That would make extension of the context easier as well in the
future. Or so.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-08-13 11:43    [W:0.050 / U:1.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site