Messages in this thread | | | Date | Mon, 13 Aug 2012 12:01:20 +0400 | From | Glauber Costa <> | Subject | Re: [PATCH v2 09/11] memcg: propagate kmem limiting information to children |
| |
On 08/10/2012 09:51 PM, Kamezawa Hiroyuki wrote: >> + /* >> + * Once enabled, can't be disabled. We could in theory disable >> + * it if we haven't yet created any caches, or if we can shrink >> + * them all to death. But it is not worth the trouble >> + */ >> static_key_slow_inc(&memcg_kmem_enabled_key); >> - memcg->kmem_accounted = true; >> + >> + if (!memcg->use_hierarchy) >> + goto out; >> + >> + for_each_mem_cgroup_tree(iter, memcg) { >> + if (iter == memcg) >> + continue; >> + memcg_kmem_account_parent(iter); >> + } > > Could you add an explanation comment ? >
Of course, Kame. Thanks
| |