Messages in this thread | | | Date | Mon, 13 Aug 2012 16:04:44 -0500 | From | Seth Forshee <> | Subject | Re: [PATCH 2/2] apple_gmux: Add support for newer hardware |
| |
On Mon, Aug 13, 2012 at 04:20:32PM -0400, Matthew Garrett wrote: > +static int gmux_index_wait_ready(struct apple_gmux_data *gmux_data) > +{ > + int i = 200; > + u8 gwr = inb(gmux_data->iostart + GMUX_PORT_WRITE); > + > + while (i && (gwr & 0x01)) { > + inb(gmux_data->iostart + GMUX_PORT_READ); > + gwr = inb(gmux_data->iostart + GMUX_PORT_WRITE); > + msleep(100);
Wouldn't it make more sense if the msleep was before reading the port again? Otherwise there's no substantial dely between the first and second times we read it.
> +static int gmux_index_wait_complete(struct apple_gmux_data *gmux_data) > +{ > + int i = 200; > + u8 gwr = inb(gmux_data->iostart + GMUX_PORT_WRITE); > + > + while (i && (gwr & 0x01)) { > + gwr = inb(gmux_data->iostart + GMUX_PORT_WRITE); > + msleep(100);
Likewise.
| |