Messages in this thread | | | Date | Mon, 13 Aug 2012 09:32:19 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 2/5] workqueue: change value of lcpu in queue_delayed_work_on() |
| |
Hello,
On Tue, Aug 14, 2012 at 01:17:49AM +0900, Joonsoo Kim wrote: > We assign cpu id into work struct in queue_delayed_work_on(). > In current implementation, when work is come in first time, > current running cpu id is assigned. > If we do queue_delayed_work_on() with CPU A on CPU B, > __queue_work() invoked in delayed_work_timer_fn() go into sub-optimal path > in case of WQ_NON_REENTRANT. > Change it to cpu argument is prevent to go into sub-optimal path.
Which part is suboptimal? Also, what if @cpu is WQ_UNBOUND?
Thanks.
-- tejun
| |