Messages in this thread | | | Subject | Re: [RFC][PATCH 4/4] perf/events: Use helper functions in event assignment to shrink macro size | From | Steven Rostedt <> | Date | Mon, 13 Aug 2012 10:40:44 -0400 |
| |
On Mon, 2012-08-13 at 15:52 +0200, Peter Zijlstra wrote:
> > Looking at the history of perf_trace_buf_submit(), it use to be more > > than one function call. But when you inlined > > perf_swevent_put_recursion_context(), it became just a one2one mapping. > > Right.
OK, this should go as a separate change.
> > > I'm assuming that we want to convert all calls to > > perf_trace_buf_submit()s into perf_tp_event()? > > Yeah.. I think you're referring to the {u,k}probes open-coded nonsense? > Should we make those use these new helpers you created as well?
They may not need it. The helpers I created were for the macros that are created by all TRACE_EVENT() instances. If the uprobes and kprobes only have a single instance, then they probably don't need the helpers. But they still call the perf_trace_buf_submit(), which can can probably be cleaned up.
-- Steve
| |