Messages in this thread | | | Subject | Re: [PATCH] be2iscsi: cleanup format strings using literal string concatenations | From | Joe Perches <> | Date | Sun, 12 Aug 2012 10:05:04 -0700 |
| |
On Mon, 2012-08-13 at 00:25 +0900, Masatake YAMATO wrote: > In format strings for printk in be2iscsi, literal c string > concatenations are used widely. However, the log output is a bit > difficult to read because whitespaces are missed in the literal c > strings like: > > SE_DEBUG(DBG_LVL_1, "CQ Error %d, reset" > "received/sent on CID 0x%x...\n", > > You will see "CQ Error 0xffffffff resetreceived/sent on CID ..." and > wonder what is "resetreceived".
It'd be even better to coalesce the formats so they'd be easier to grep. Just ignore 80 columns.
SE_DEBUG(DBG_LVL_1, "CQ Error %d, reset received/sent on CID 0x%x...\n",
| |