lkml.org 
[lkml]   [2012]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH] block: Don't use static to define "void *p" in show_partition_start().
On 2012-08-12 23:45 Michael Tokarev <mjt@tls.msk.ru> Wrote:
>On 03.08.2012 12:41, Jens Axboe wrote:
>> On 08/03/2012 07:07 AM, majianpeng wrote:
>[]
>>> diff --git a/block/genhd.c b/block/genhd.c
>>> index cac7366..d839723 100644
>>> --- a/block/genhd.c
>>> +++ b/block/genhd.c
>>> @@ -835,7 +835,7 @@ static void disk_seqf_stop(struct seq_file *seqf, void *v)
>>>
>>> static void *show_partition_start(struct seq_file *seqf, loff_t *pos)
>>> {
>>> - static void *p;
>>> + void *p;
>>>
>>> p = disk_seqf_start(seqf, pos);
>>> if (!IS_ERR_OR_NULL(p) && !*pos)
>>
>> Huh, that looks like a clear bug. I've applied it, thanks.
>
>It also looks like a -stable material, don't you think?
>
>Thanks,
>
>/mjt
>
Yes, all kernel before this patach had this problem and should apply this patch.
\
 
 \ /
  Last update: 2012-08-13 03:22    [W:0.075 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site