Messages in this thread | | | Date | Mon, 09 Jul 2012 22:34:37 +0200 | From | Lee Jones <> | Subject | Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping |
| |
> Why do you keep these assignments and then override them with > translations? Why don't you do > > ponkey->idev = input; > ponkey->ab8500 = ab8500; > ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf); > ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr); > > to begin with?
Ah, I see what you mean now.
Sorry, just glossed over your first email.
| |