lkml.org 
[lkml]   [2012]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix checkpatch.pl issue.
On 07/08/2012 10:16 AM, Toshiaki Yamane wrote:
> -printk(KERN_ERR, to pr_err(...
>
> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>

Hi

I submit that your subject line should be more descriptive. Perhaps
something like the following:

[PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)

The rest of your commit message could then clarify that this change was
inspired by checkpatch.

HTH, Jan


\
 
 \ /
  Last update: 2012-07-08 11:01    [W:0.038 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site