Messages in this thread | | | Date | Sun, 08 Jul 2012 10:36:25 +0200 | From | Jan Ceuleers <> | Subject | Re: [PATCH] Fix checkpatch.pl issue. |
| |
On 07/08/2012 10:16 AM, Toshiaki Yamane wrote: > -printk(KERN_ERR, to pr_err(... > > Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
Hi
I submit that your subject line should be more descriptive. Perhaps something like the following:
[PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)
The rest of your commit message could then clarify that this change was inspired by checkpatch.
HTH, Jan
| |