lkml.org 
[lkml]   [2012]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 05/11] fblog: register one fblog object per framebuffer
From
Date
On Sun, 2012-07-08 at 23:56 +0200, David Herrmann wrote:
>

Hi David. Trivial comments only:

> diff --git a/drivers/video/console/fblog.c b/drivers/video/console/fblog.c
[]
> @@ -23,15 +23,204 @@
> * all fblog instances before running other graphics applications.
> */

Please add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any #include and...

> static int __init fblog_init(void)
> {
> + int ret;
> +
> + ret = fb_register_client(&fblog_notifier);
> + if (ret) {
> + pr_err("fblog: cannot register framebuffer notifier");

Missing newline, pr_fmt would add module name.

pr_err("cannot register framebuffer notifier\n");





\
 
 \ /
  Last update: 2012-07-09 00:41    [W:0.140 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site