lkml.org 
[lkml]   [2012]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/19] Staging: xgifb: Comment cleaning.
Hi!

> Some minor comments below:
>
>> -/*
>> - * XG20, XG21, XG40, XG42 frame buffer device
>> - * for Linux kernels 2.5.x, 2.6.x
>> - * Base on TW's sis fbdev code.
>
> A lot of code was copy-pasted from Thomas Winischhofer's sisfb driver,
> I'm not sure if it's OK to remove the credit...?

You're right. I'll keep the credit.

>> - /* TW: We can't switch off CRT1 on LVDS/Chrontel
>> + /* We can't switch off CRT1 on LVDS/Chrontel
>> * in 8bpp Modes */
>> if ((xgifb_info->hasVB == HASVB_LVDS) ||
>> (xgifb_info->hasVB == HASVB_LVDS_CHRONTEL)) {
>> doit = 0;
>> }
>> - /* TW: We can't switch off CRT1 on 301B-DH
>> + /* We can't switch off CRT1 on 301B-DH
>> * in 8bpp Modes if using LCD */
>
> These could be also fixed according to multiline comment style at the
> same go.

Written down for the next version ;)

>> diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h
>> index a27b4fe..be5589c 100644
>> --- a/drivers/staging/xgifb/vb_init.h
>> +++ b/drivers/staging/xgifb/vb_init.h
>> @@ -3,4 +3,3 @@
>> extern unsigned char XGIInitNew(struct pci_dev *pdev);
>> extern struct XGI21_LVDSCapStruct XGI21_LCDCapList[13];
>> #endif
>> -
> [...]
>> diff --git a/drivers/staging/xgifb/vb_util.h b/drivers/staging/xgifb/vb_util.h
>> index 9161de1..ff40247 100644
>> --- a/drivers/staging/xgifb/vb_util.h
>> +++ b/drivers/staging/xgifb/vb_util.h
>> @@ -6,4 +6,3 @@ extern void xgifb_reg_or(unsigned long, u8, unsigned);
>> extern void xgifb_reg_and(unsigned long, u8, unsigned);
>> extern void xgifb_reg_and_or(unsigned long, u8, unsigned, unsigned);
>> #endif
>> -
>
> These changes are not really "comment cleaning".

Mmmm no they aren't... seems I committed them by mistake while I was
berserker cleaning XD... I'll remove them.

--
Miguel Gómez
Igalia - http://www.igalia.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-07-06 10:41    [W:0.137 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site