lkml.org 
[lkml]   [2012]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Subject: [PATCH] tty ldisc: Close/Reopen race prevention should check the proper flag
    On Sun, Jul 01, 2012 at 09:53:19AM +0300, Shachar Shemesh wrote:
    > From: Shachar Shemesh <shachar@liveu.tv>
    >
    > Commit acfa747b introduced the TTY_HUPPING flag to distinguish
    > closed TTY from currently closing ones. The test in tty_set_ldisc
    > still remained pointing at the old flag. This causes pppd to
    > sometimes lapse into uninterruptible sleep when killed and
    > restarted.
    >
    > Signed-off-by: Shachar Shemesh <shachar@liveu.tv>
    > ---
    > Tested with 3.2.20 kernel.
    >
    > diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
    > index 24b95db..a662a24 100644
    > --- a/drivers/tty/tty_ldisc.c
    > +++ b/drivers/tty/tty_ldisc.c
    > @@ -658,7 +658,7 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc)
    > goto enable;
    > }
    >
    > - if (test_bit(TTY_HUPPED, &tty->flags)) {
    > + if (test_bit(TTY_HUPPING, &tty->flags)) {

    All tabs are converted to spaces and make this patch impossible to apply
    :(

    Care to try again?

    greg k-h


    \
     
     \ /
      Last update: 2012-07-06 23:41    [W:2.620 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site