Messages in this thread | | | From | (Eric W. Biederman) | Date | Fri, 06 Jul 2012 02:51:02 -0700 | Subject | Re: [PATCH v2] fail dentry revalidation after namespace change |
| |
Glauber Costa <glommer@parallels.com> writes:
> On 07/06/2012 01:37 PM, Eric W. Biederman wrote: >> Glauber Costa <glommer@parallels.com> writes: >> >>> When we change the namespace tag of a sysfs entry, the associated dentry >>> is still kept around. readdir() will work correctly and not display the >>> old entries, but open() will still succeed, so will reads and writes. >> >> Note reads and writes of file handles open before the move should >> continue to work. > > Well, yes. But do you see it as a big problem? > > This can probably be fixed as well, but I foresee a big hackishness in > the way =p
At the moment it looks like a feature.
The only reason we bounce between different instances of sysfs is because of the unfortunate sysfs directory layout that we need to remain compatible with.
But I don't see it making much of a difference either way.
Eric
| |