lkml.org 
[lkml]   [2012]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/28] x86/irq: Use irq_remap specific print_IO_APIC paths only on Intel

* Joerg Roedel <joerg.roedel@amd.com> wrote:

> The VT-d IOMMU requires a special setup of the IO-APIC to
> remap its interrupts. Therefore the print_IO_APIC routine
> has seperate code paths to accout for that and print out the
> special setup. This is not required on AMD IOMMU systems, so
> make these path really Intel specific.
>
> Cc: x86@kernel.org
> Cc: Yinghai Lu <yinghai@kernel.org>
> Cc: Suresh Siddha <suresh.b.siddha@intel.com>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
> arch/x86/include/asm/irq_remapping.h | 2 ++
> arch/x86/kernel/apic/io_apic.c | 4 ++--
> drivers/iommu/intel_irq_remapping.c | 2 ++
> drivers/iommu/irq_remapping.c | 1 +
> 4 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/irq_remapping.h b/arch/x86/include/asm/irq_remapping.h
> index 5fb9bbb..228d5e5 100644
> --- a/arch/x86/include/asm/irq_remapping.h
> +++ b/arch/x86/include/asm/irq_remapping.h
> @@ -27,6 +27,7 @@
> #ifdef CONFIG_IRQ_REMAP
>
> extern int irq_remapping_enabled;
> +extern int intel_irq_remap_debug;

Sigh.

Instead of yet another set of global flags thrown around the
kernel please properly factor out this code, its data structures
and methods: introduce a single descriptor structure that
describes this piece of hardware, with debugging flags part of
this structure - with operations function pointer structure and
such.

This code came from the "we have a single, known type of system
global IOMMU" world - and we now want to transform this into
something that is properly abstracted out and made flexible, as
we extend its capabilities .

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-07-06 12:01    [W:0.231 / U:2.876 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site