Messages in this thread | | | Date | Fri, 06 Jul 2012 10:16:36 +0200 | From | Miguel Gómez <> | Subject | Re: [PATCH 17/19] Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs(). |
| |
> On Thu, Jul 05, 2012 at 04:46:00PM +0200, Miguel Gómez wrote: >> Rework some conditions to reduce indentation and fix style warnings. >> > > Instead of a do { } while(0); it would be better to just use gotos.
Point taken. I used the do-while because I didn't want to abuse gotos, but if there's no problem with them I'll change the patch.
I'll also change your comments in previous email about the comments ;)
Regards!
-- Miguel Gómez Igalia - http://www.igalia.com
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |