[lkml]   [2012]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 01/10] random: make 'add_interrupt_randomness()' do something sane
On Thu, Jul 5, 2012 at 2:39 PM, Matt Mackall <> wrote:
> From my read, this code path gets called on timer interrupts too.

That's hopefully never true for any normal cases (timers are *very*
special - they tend to go through their own architecture-specific
stuff). On modern PC's, for example, the timers happen through the
local apic timers directly.

In fact, with SMP, it's a really bad idea to use a normal irq for
timer interrupts, since you really really want per-CPU-core timers.

But yes, we should probably make sure that *if* the architecture uses
regular interrupts for timers we don't count them. The problematic
embedded platforms are often pretty crap hardware: even when they are
SMP, they might use an external timer irq (and then we broadcast the
thing). I think we have the IRQF_TIMER flag for that, so we could add
a check for that.


 \ /
  Last update: 2012-07-06 00:01    [W:0.065 / U:50.744 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site