lkml.org 
[lkml]   [2012]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 15/19] Staging: xgifb: Rework conditions in XGI_SetLockRegs().
    Hi,

    On Thu, Jul 05, 2012 at 04:45:58PM +0200, Miguel Gómez wrote:
    > + if ((pVBInfo->VBType & VB_SIS301LV) &&
    > + !(pVBInfo->TVInfo & TVSetHiVision)) {
    > + if ((pVBInfo->TVInfo & TVSimuMode) &&
    > + (pVBInfo->TVInfo & TVSetPAL)) {
    > + if (pVBInfo->VBType & VB_SIS301LV) {
    > + if (!(pVBInfo->TVInfo &
    > + (TVSetYPbPr525p |
    > + TVSetYPbPr750p |
    > + TVSetHiVision)))
    > + tempbx += 40;
    > + } else {
    > + tempbx += 40;

    I think this could be simplified even more - both branches end up doing
    the same?!

    A.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-07-05 20:41    [W:2.515 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site