lkml.org 
[lkml]   [2012]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/23 v6] Input: atmel_mxt_ts - warn if sysfs could not be created
Hi Daniel, Henrik,

On Thu, Jun 28, 2012 at 09:08:05PM +0800, Daniel Kurtz wrote:
> If sysfs entry creation fails, the driver is still usable, so don't
> just abort probe. Just warn and continue.
>

I understand that I am a bit late to the party :) but I do not agree
with this change. Failure to create attributes is not sometihng that
user could cause (at least not easily) and thus would not be a setup
issue but something more severe. I believe we should fail loading the
driver so sysfs attribute breakage will be noticed as soon as possible,
instead of discovering it much much later in the process.

So I think we should revert this one.

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2012-07-05 20:01    [W:0.137 / U:4.408 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site