lkml.org 
[lkml]   [2012]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 11/20] tools lib traceevent: Do not call add_event() again if allocation failed
    Date
    From: Namhyung Kim <namhyung.kim@lge.com>

    When memory allocation for the field name is failed, do not goto
    event_failed since we added the event already.

    Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Arnaldo Carvalho de Melo <acme@infradead.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: David Ahern <dsahern@gmail.com>
    Link: http://lkml.kernel.org/r/1335157118-14658-8-git-send-email-namhyung.kim@lge.com
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    ---
    tools/lib/traceevent/event-parse.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
    index 337ca02..99b0cd4 100644
    --- a/tools/lib/traceevent/event-parse.c
    +++ b/tools/lib/traceevent/event-parse.c
    @@ -4770,7 +4770,8 @@ int pevent_parse_event(struct pevent *pevent,
    arg->field.name = strdup(field->name);
    if (!arg->field.name) {
    do_warning("failed to allocate field name");
    - goto event_failed;
    + event->flags |= EVENT_FL_FAILED;
    + return -1;
    }
    arg->field.field = field;
    }
    --
    1.7.9.2.358.g22243


    \
     
     \ /
      Last update: 2012-07-05 18:21    [W:4.304 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site