lkml.org 
[lkml]   [2012]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Patch] mm/policy: use int instead of unsigned for nid
Date
On Wed, 04 Jul 2012 at 06:43 GMT, David Rientjes <rientjes@google.com> wrote:
> On Wed, 4 Jul 2012, Cong Wang wrote:
>
>> From: WANG Cong <xiyou.wangcong@gmail.com>
>>
>> 'nid' should be 'int', not 'unsigned'.
>>
>
> unsigned is already of type int, so you're saying these occurrences should
> become signed, but that's not true since they never return NUMA_NO_NODE.
> They are all safe returning unsigned.
>

Yeah, I knew, just thought using 'int' is consistent, this is a
trivial patch, not a bugfix.

> And alloc_page_interleave() doesn't exist anymore since the sched/numa
> bits were merged into sched/core, so nobody could apply this patch anyway.

Ah, I made this patch against linus tree...



\
 
 \ /
  Last update: 2012-07-05 16:21    [W:0.045 / U:0.124 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site