lkml.org 
[lkml]   [2012]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] printk: fixing the deadlock when calling printk in nmi handle
Date
> -----Original Message-----
> From: Peter Zijlstra [mailto:peterz@infradead.org]
> Sent: Wednesday, July 04, 2012 10:52 PM
> To: Liu, Chuansheng
> Cc: 'linux-kernel@vger.kernel.org' (linux-kernel@vger.kernel.org); kay@vrfy.org;
> gregkh@linuxfoundation.org; mingo@elte.hu
> Subject: RE: [PATCH] printk: fixing the deadlock when calling printk in nmi
> handle
>
> On Wed, 2012-07-04 at 16:50 +0200, Peter Zijlstra wrote:
> > On Wed, 2012-07-04 at 14:46 +0000, Liu, Chuansheng wrote:
> > > > > I took many time to dig out this issue.
> > > >
> > > > Well, it was a known issue..
> > > Still feel unfair :)
> > > If this is a known issue that calling printk is not safe in nmi
> > > handler, Why not defense it like this patch before real solution coming out?
> >
> > Why replace one broken thing with another broken thing?
>
> Also, I much prefer obviously broken over subtly broken.
Supporting your opinion totally, but from production view, it is not a good thing that system crash,
I prefer to lose one log instead:)
\
 
 \ /
  Last update: 2012-07-04 17:41    [W:0.043 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site