Messages in this thread | | | Subject | RE: [PATCH] printk: fixing the deadlock when calling printk in nmi handle | From | Peter Zijlstra <> | Date | Wed, 04 Jul 2012 15:39:37 +0200 |
| |
On Wed, 2012-07-04 at 13:30 +0000, Liu, Chuansheng wrote: > > Yuck.. and no. This makes sane things like early 8250 serial console less > > reliable. > Peter, could you share more?
You avoid calling console write, this delays writing the output, this delay might be infinite if the machine is sick enough.
Things like the 8250 early console don't take locks and are fine to call.
> I took many time to dig out this issue.
Well, it was a known issue..
> Anyway, in nmi handler, calling printk is dangerous. This patch is for this case.
But its ugly and decreases reliability.. Your 'solution' is to basically ignore serialization and pray, that's not a solution, that's gambling.
| |