Messages in this thread | | | From | Kukjin Kim <> | Subject | RE: [PATCH] gpio: samsung: Fix off-by-one bug in gpio addresses | Date | Wed, 01 Aug 2012 08:27:45 +0900 |
| |
Linus Walleij wrote: > > On Fri, Jul 20, 2012 at 10:58 PM, Sean Paul <seanpaul@chromium.org> wrote: > > > Move gpc4 to the end of the automatically processed gpio controllers so > > we don't taint the automatic offset calculation. > > > > This bug caused all controllers coming after gpc4 to map to the > > incorrect address. The result is <&gpd1 0 0 0 0> would actually map to > > GPIO 0 in gpd0. > > > > Signed-off-by: Sean Paul <seanpaul@chromium.org> > > Samsung people, please comment on this patch. > Looks good to me, please keep going on. And feel free to add my ack on this.
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks.
Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
| |