Messages in this thread | | | Date | Tue, 31 Jul 2012 11:39:02 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH] floppy: remove duplicated flag FD_RAW_NEED_DISK |
| |
On Sat, 28 Jul 2012, Fengguang Wu wrote:
> Fix coccinelle warning (without behavior change): > > drivers/block/floppy.c:2518:32-48: duplicated argument to & or | > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > > diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c > index 553f43a..0fcbe14 100644 > --- a/drivers/block/floppy.c > +++ b/drivers/block/floppy.c > @@ -2516,8 +2516,7 @@ static int make_raw_rw_request(void) > set_fdc((long)current_req->rq_disk->private_data); > > raw_cmd = &default_raw_cmd; > - raw_cmd->flags = FD_RAW_SPIN | FD_RAW_NEED_DISK | FD_RAW_NEED_DISK | > - FD_RAW_NEED_SEEK; > + raw_cmd->flags = FD_RAW_SPIN | FD_RAW_NEED_DISK | FD_RAW_NEED_SEEK; > raw_cmd->cmd_count = NR_RW; > if (rq_data_dir(current_req) == READ) { > raw_cmd->flags |= FD_RAW_READ;
Now that's a funny one. Applied, thanks.
-- Jiri Kosina SUSE Labs
| |