lkml.org 
[lkml]   [2012]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v2 2/2] net: Add support for NTB virtual ethernet device
Mon, Jul 30, 2012 at 08:19:11PM CEST, jon.mason@intel.com wrote:
>On Mon, Jul 30, 2012 at 04:02:16PM +0200, Jiri Pirko wrote:
>> Mon, Jul 30, 2012 at 02:26:34AM CEST, jon.mason@intel.com wrote:
>> >+static int __devinit ntb_netdev_probe(struct pci_dev *pdev)
>> >+{
>> >+ struct net_device *ndev;
>> >+ struct ntb_netdev *dev;
>> >+ int rc;
>> >+
>> >+ ndev = alloc_etherdev(sizeof(struct ntb_netdev));
>> >+ if (!ndev)
>> >+ return -ENOMEM;
>> >+
>> >+ dev = netdev_priv(ndev);
>> >+ dev->ndev = ndev;
>> >+ dev->pdev = pdev;
>> >+ BUG_ON(!dev->pdev);
>> >+ ndev->features = NETIF_F_HIGHDMA;
>> >+
>> >+ //ndev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
>> ^^ I guess you forgot to un-comment this.
>
>Oops. An easy fix. Anything else?

The rest looks good to me.

>
>Thanks,
>Jon


\
 
 \ /
  Last update: 2012-07-30 23:01    [W:0.066 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site