lkml.org 
[lkml]   [2012]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 40/41] mm/hugetlb: fix warning in alloc_huge_page/dequeue_huge_page_vma
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.0-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Konstantin Khlebnikov <khlebnikov@openvz.org>

    commit b1c12cbcd0a02527c180a862e8971e249d3b347d upstream.

    Stable note: Not tracked in Bugzilla. [get|put]_mems_allowed() is extremely
    expensive and severely impacted page allocator performance. This
    is part of a series of patches that reduce page allocator overhead.

    Fix a gcc warning (and bug?) introduced in cc9a6c877 ("cpuset: mm: reduce
    large amounts of memory barrier related damage v3")

    Local variable "page" can be uninitialized if the nodemask from vma policy
    does not intersects with nodemask from cpuset. Even if it doesn't happens
    it is better to initialize this variable explicitly than to introduce
    a kernel oops in a weird corner case.

    mm/hugetlb.c: In function `alloc_huge_page':
    mm/hugetlb.c:1135:5: warning: `page' may be used uninitialized in this function

    Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
    Acked-by: Mel Gorman <mgorman@suse.de>
    Acked-by: David Rientjes <rientjes@google.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Mel Gorman <mgorman@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    mm/hugetlb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/mm/hugetlb.c
    +++ b/mm/hugetlb.c
    @@ -454,7 +454,7 @@ static struct page *dequeue_huge_page_vm
    struct vm_area_struct *vma,
    unsigned long address, int avoid_reserve)
    {
    - struct page *page;
    + struct page *page = NULL;
    struct mempolicy *mpol;
    nodemask_t *nodemask;
    struct zonelist *zonelist;



    \
     
     \ /
      Last update: 2012-07-30 20:41    [W:4.342 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site