lkml.org 
[lkml]   [2012]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Regression 3.4] tick_broadcast_mask is not restored after a CPU has been offline/onlined
    On Mon, Jul 30, 2012 at 11:07:47PM +0800, Feng Tang wrote:
    > Hi Paul,
    >
    > On Mon, 30 Jul 2012 06:39:13 -0700
    > "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
    >
    > > On Mon, Jul 30, 2012 at 03:15:59PM +0800, Feng Tang wrote:
    > > > Hi All,
    > > >
    > > > When I debugged a suspend/resume bug, I found that tick_broadcast_mask is
    > > > not restored for a CPU after it is offline/onlined since kernel 3.4, while
    > > > it's fine for 3.3.
    > >
    > > Could you please try 3.5?
    >
    > Yes, it's the same for 3.5

    Thank you for checking, Feng.

    Len, the comment above the change says:

    /*
    * FIXME: Design the ACPI notification to make it once per
    * system instead of once per-cpu. This condition is a hack
    * to make the code that updates C-States be called once.
    */

    Is it time for this design-level change? Or is there something obvious
    that I missed when fixing the smp_processor_id() splat?

    I could revert back, but use raw_smp_processor_id() rather than
    smp_processor_id(), but that feels like papering over a problem rather
    than fixing it.

    Thoughts?

    Thanx, Paul



    \
     
     \ /
      Last update: 2012-07-30 19:41    [W:0.022 / U:178.580 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site