lkml.org 
[lkml]   [2012]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -mm v2 01/11] mm: track free size between VMAs in VMA rbtree
From
On Tue, Jul 3, 2012 at 2:37 PM, Rik van Riel <riel@redhat.com> wrote:
> On 06/29/2012 07:46 PM, Michel Lespinasse wrote:
>> Basically, I think lib/rbtree.c should provide augmented rbtree support
>> in the form of (versions of) rb_insert_color() and rb_erase() being able
>> to
>> callback to adjust the augmented node information around tree rotations,
>> instead of using (conservative, overkill) loops to adjust the augmented
>> node information after the fact
>
> That is what I originally worked on.
>
> I threw out that code after people told me (at LSF/MM) in
> no uncertain terms that I should use the augmented rbtree
> code :)

Well, bummer. Could you summarize what their argument was ? In other
words, what are the constraints besides not adding overhead to the
scheduler rbtree use case and keeping the code size reasonable ?

--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.


\
 
 \ /
  Last update: 2012-07-04 01:41    [W:0.082 / U:14.344 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site