Messages in this thread | | | From | Kay Sievers <> | Date | Tue, 3 Jul 2012 13:21:01 +0200 | Subject | Re: [patch] printk: remove some dead code |
| |
On Tue, Jul 3, 2012 at 12:45 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > Static checkers complain about the impossible condition here. > > In 084681d14e ('printk: flush continuation lines immediately to > console'), we changed msg->level from being a u16 to being an unsigned > 3 bit bitfield. That means we can remove the code here to handle log > levels which are in the tens or hundreds column.
We should do that for the facility value, now that level is split up in separate fields. I'll prepare a fix.
Thanks, Kay
| |