lkml.org 
[lkml]   [2012]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ivtv: Declare MODULE_FIRMWARE usage
From
Date
On Fri, 2012-07-27 at 09:45 -0600, Tim Gardner wrote:
> On 07/26/2012 04:21 PM, Andy Walls wrote:
> > On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote:
> >> Cc: Andy Walls <awalls@md.metrocast.net>
> >> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
> >> Cc: ivtv-devel@ivtvdriver.org
> >> Cc: linux-media@vger.kernel.org
> >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> >> ---
> >> drivers/media/video/ivtv/ivtv-firmware.c | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c
> >> index 02c5ade..6ec7705 100644
> >> --- a/drivers/media/video/ivtv/ivtv-firmware.c
> >> +++ b/drivers/media/video/ivtv/ivtv-firmware.c
> >> @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where)
> >>
> >> return res;
> >> }
> >> +
> >> +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME);
> >> +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME);
> >> +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME);
> >
> > Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the
> > CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even
> > in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME
> > file is non-fatal.)
> >
> > I would not want anything in user-space or kernel space preventing the
> > ivtv module from loading, if some of those files don't exist.
> >
> > Regards,
> > Andy
> >
>
> MODULE_FIRMWARE is informational only and has no runtime impact.

OK.

Acked-by: Andy Walls <awalls@md.metrocast.net>

Regards,
Andy

>
> rtg




\
 
 \ /
  Last update: 2012-07-28 19:41    [W:0.058 / U:3.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site