Messages in this thread | | | Date | Fri, 27 Jul 2012 15:28:25 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] NVMe: Add a character device for each nvme device |
| |
On 07/27/2012 02:12 PM, Matthew Wilcox wrote: > On Fri, Jul 27, 2012 at 10:44:18AM -0600, Keith Busch wrote: >> Registers a character device for the nvme module and creates character >> files as /dev/nvmeN for each nvme device probed, where N is the device >> instance. The character devices support nvme admin ioctl commands so >> that nvme devices without namespaces can be managed. > > I don't see a problem here, but I'm no expert at sysfs / character devices. > Alan, Greg, anyone else see any problems with how this character device is > created / destroyed?
This seems like something normally done via a control device that is addressible via bsg.
This is -not- a NAK, but maybe the storage folks have a different preference for an admin-command path.
Jeff
| |