Messages in this thread | | | From | Michael Kerrisk <> | Date | Fri, 27 Jul 2012 09:07:25 +0200 | Subject | Re: [PATCH 00/13] UAPI header file split |
| |
On Thu, Jul 26, 2012 at 12:46 PM, David Howells <dhowells@redhat.com> wrote: > Michael Kerrisk <mtk.manpages@gmail.com> wrote: > >> >> >> 3. HEADER COMMENTS NOT RETAINED IN KAPI FILES >> > >> > How about the attached changes? This is a delta to the disintegrate markers >> > diff I sent earlier. >> >> That looks about right to me. >> >> Acked-by: Michael Kerrisk <mtk.manpages@gmail.com> > > Excellent, thanks. The question is where can I attach your ack? I'm not > going to simply tag these on the end as a new patch, but rather the changes > are included in the regenerated patches as I changed the scripts. > > So just the main set of scripted commits?
Modulo the following statements: * The conceptual approach of your scripts makes sense to me. * I checked a significant, but far from complete, sample of the output files, and the results look correct. * My comparator scripts support the belief that no content is being lost in the resulting header files (once you've made the changes noted yesterday).
then you could add my Acked-by: for the commits generated by the scripts.
Acked-by: Michael Kerrisk <mtk.manpages@gmail.com>
Cheers,
Michael
-- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Author of "The Linux Programming Interface", http://blog.man7.org/
| |