lkml.org 
[lkml]   [2012]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/3] KVM: remove dummy pages
On Thu, 26 Jul 2012 17:35:13 +0800
Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> wrote:

> > Is this patch really safe for all architectures?
> >
> > IS_ERR_VALUE() casts -MAX_ERRNO to unsigned long and then does comparison.
> > Isn't it possible to conflict with valid pfns?
> >
>
> See IS_ERR_VALUE():
>
> #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
>
> The minimal value of the error code is:
> 0xffff f001 on 32-bit and 0x ffff ffff ffff f001 on 64-bit,
> it is fair larger that a valid pfn (for the pfn, the most top of 12 bits
> are always 0).
>
> Note, PAE is a special case, but only 64G physical memory is valid,
> 0xffff f001 is also suitable for that.

Ah, I see. I misread the type pfn_t and was confused.
Thank you!

Takuya


\
 
 \ /
  Last update: 2012-07-26 12:41    [W:1.482 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site