lkml.org 
[lkml]   [2012]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] sched: recover SD_WAKE_AFFINE in select_task_rq_fair and code clean up
On 07/26/2012 05:37 PM, Mike Galbraith wrote:

> On Thu, 2012-07-26 at 13:27 +0800, Alex Shi wrote:
>
>> if (affine_sd) {
>> - if (cpu == prev_cpu || wake_affine(affine_sd, p, sync))
>> + if (wake_affine(affine_sd, p, sync))
>> prev_cpu = cpu;
>>
>> new_cpu = select_idle_sibling(p, prev_cpu);
>
> Hm, if cpu == prev_cpu, asking wake_affine() if it's ok to put wakee
> back where it came from is wasted cycles.. that's where the task is
> headed regardless of reply.


Sure. You'r right.

>
> -Mike
>




\
 
 \ /
  Last update: 2012-07-26 12:21    [W:0.100 / U:1.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site