lkml.org 
[lkml]   [2012]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging/olpc_dcon: fix checkpatch warnings
From
On Fri, Jul 27, 2012 at 10:40 AM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2012-07-27 at 08:49 +0900, Toshiaki Yamane wrote:
>> Now checkpatch clean.
> []
>> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> []
>> @@ -11,6 +11,7 @@
> []
>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> []
>> @@ -71,18 +72,18 @@ static int dcon_hw_init(struct dcon_priv *dcon, int is_init)
>>
>> ver = dcon_read(dcon, DCON_REG_ID);
>> if ((ver >> 8) != 0xDC) {
>> - printk(KERN_ERR "olpc-dcon: DCON ID not 0xDCxx: 0x%04x instead.\n",
>> - ver);
>> + pr_err("olpc-dcon: DCON ID not 0xDCxx: 0x%04x instead.\n",
>> + ver);
>> rc = -ENXIO;
>> goto err;
>> }
>>
>> if (is_init) {
>> - printk(KERN_INFO "olpc-dcon: Discovered DCON version %x\n",
>> - ver & 0xFF);
>> + pr_info("olpc-dcon: Discovered DCON version %x\n",
>> + ver & 0xFF);
>
> Hello.
>
> Please remove all the embedded "olpc-dcon: " prefixes.
> There is a pr_fmt define that adds "olpc_dcon" already.
>
> You can use the strings program on the output .o files to
> verify the formats that are produced.
>

Thanks for your reply.

I was able to check for duplicates in strings.
I will try to fix with care.




--

Regards,


.
.
...

Yamane Toshiaki

yamanetoshi@gmail.com


\
 
 \ /
  Last update: 2012-07-27 05:01    [W:0.115 / U:3.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site