lkml.org 
[lkml]   [2012]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH v3 1/4] ACPI: Add acpi_pr_<level>() interfaces
From
Date
On Thu, 2012-07-26 at 15:37 -0600, Bjorn Helgaas wrote:
> PNP0C01:00: new device for \_SB_.PCI0.ISA_.MBIO
>
> I fiddled with this a while ago; it would look something like this:
[]
> +static noinline_for_stack
> +char *acpi_name_string(char *buf, char *end, acpi_handle handle,
> + struct printf_spec spec, const char *fmt)
> +{
> + acpi_status status;
> + struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> + u32 type = ACPI_SINGLE_NAME;
> + char *p = buf;
> +
> + if (fmt[0] == 'A')
> + type = ACPI_FULL_PATHNAME;

maybe if (fmt[1] == 'f')

> @@ -982,6 +1007,9 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr,
> }
>
> switch (*fmt) {
> + case 'A':
> + case 'a':
> + return acpi_name_string(buf, end, ptr, spec, fmt);

There are only so many letters, it might be better to
just use 'a' and another 'f' after that if necessary
for "full".

And of course that should be #ifdef'd too

cheers, Joe


\
 
 \ /
  Last update: 2012-07-27 04:41    [W:0.077 / U:1.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site