lkml.org 
[lkml]   [2012]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 17/21] ASoC: Ux500: Enable ux500 PCM driver for Device Tree
On 26/07/12 15:22, Mark Brown wrote:
> On Thu, Jul 26, 2012 at 02:52:09PM +0100, Lee Jones wrote:
>> On 26/07/12 12:38, Mark Brown wrote:
>
>>>> - pr_info("%s: Register platform-device 'ux500-pcm'\n", __func__);
>>>> - platform_device_register(&ux500_pcm);
>
>>> This has the same issue as your last patch... the way you're doing
>>> things will break audio on all boards using this driver.
>
>> It will, why?
>
> You've just removed registration of the device and not added anything
> else to replace that. Even if all boards convert to DT their DTs will
> need to be updated which you're not doing.

The initialisation function which calls platform_device_register() is
only executed during a DT boot. The clue is in the title
mop500_of_msp_init(). The DT is populated _before_ this patch, but I
guess you mean if they are separated into subsystem trees and are placed
into -next/Mainline out of order.

I will merge these patches with the DT population instead to overcome
this possibility. It makes more sense to keep the arch/arm stuff
together in any case.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-07-26 17:41    [W:0.073 / U:4.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site