Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver | Date | Thu, 26 Jul 2012 22:47:51 +0930 |
| |
On Fri, 20 Jul 2012 18:09:26 +0800, <wei_wang@realsil.com.cn> wrote: > +static int msi_en = 1; > +module_param(msi_en, int, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(msi_en, "Enable MSI");
Should this be a bool, and a module_param(msi_en, bool, S_IRUGO | S_IWUSR);?
> +static int adma_mode = 1; > +module_param(adma_mode, int, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(adma_mode, "ADMA Mode");
This too?
> + /* Data transferred in ADMA mode or not */ > + int adma_mode;
And this?
Cheers, Rusty.
| |