Messages in this thread | | | Subject | Re: [PATCH]net:appletalk:ddp:fixed coding style issue in net/appletalk/ddp.c | From | Joe Perches <> | Date | Thu, 26 Jul 2012 07:11:23 -0700 |
| |
On Thu, 2012-07-26 at 19:29 +0530, Jeffrin Jose wrote: > Fixed coding style issue relating to switch and case > statement in file net/appletalk/ddp.c
Don't just move the case labels, move the code blocks including comments.
> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c [] > @@ -1798,7 +1798,7 @@ static int atalk_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) > > switch (cmd) { > /* Protocol layer */ > - case TIOCOUTQ: { > + case TIOCOUTQ: { > long amount = sk->sk_sndbuf - sk_wmem_alloc_get(sk);
long amount = etc...
Post the patch with a commit message that says that that a git diff -w is empty and the compiled objects are the same too.
| |