lkml.org 
[lkml]   [2012]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kbuild: Document oldnoconfig to what it really does
On Fri, Jun 15, 2012 at 07:24:59PM -0400, Steven Rostedt wrote:
> The make target 'oldnoconfig' is a misnomer. It doesn't set new symbols
> to 'n', but instead sets it to their default values.
>
> Unfortunately, assuming that it actually did this, broke ktest in some
> of its tests. For example, the tests to create a minimum config and even
> a config bisect, depends on removing various configs and using
> oldnoconfig to get rid of other configs that may have depended on it.
>
> But because some configs that it was trying to disable, were in fact
> default enabled, this caused those configs to re-enable and corrupt the
> test.
>
> I thought about fixing oldnoconfig, but I'm afraid that people are
> already dependent on its current behavior. Instead, I'm just updating
> the documentation to state that it sets the new symbols to their default
> values and not to 'n'.
>
> Ideally, this would be called, 'olddefconfig' and we have an
> 'oldnoconfig' that actually disables the new symbols. But it's useless
> for me now. If it changed, ktest would need to be consistent between
> each version, and that would be to difficult to detect. I'll handle this
> issue with ktest with other means.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Applied to kbuild.git#kconfig, thanks.

Michal


\
 
 \ /
  Last update: 2012-07-26 15:01    [W:0.043 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site