lkml.org 
[lkml]   [2012]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/21] ASoC: io: Prevent use of regmap if request fails
On Thu, Jul 26, 2012 at 11:28:40AM +0100, Lee Jones wrote:

> @@ -52,10 +52,13 @@ static unsigned int hw_read(struct snd_soc_codec *codec, unsigned int reg)
> if (codec->cache_only)
> return -1;
>
> - ret = regmap_read(codec->control_data, reg, &val);
> - if (ret == 0)
> - return val;
> - else
> + if (codec->using_regmap) {
> + ret = regmap_read(codec->control_data, reg, &val);
> + if (ret == 0)
> + return val;
> + else
> + return -1;
> + } else

No, this makes no sense. There is no non-regmap I/O support in soc-io,
anything using the soc-io hw_read() function must be using regmap.

> case SND_SOC_REGMAP:
> /* Device has made its own regmap arrangements */
> - codec->using_regmap = true;

Again, this makes no sense. If we're explicitly being asked to use
regmap then we should be using regmap or just failing to set up I/O
(which is obviously a catastrophic failure).
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-07-26 14:01    [W:0.295 / U:1.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site