Messages in this thread Patch in this message | | | From | Jeff Layton <> | Subject | [PATCH v5 1/9] audit: remove unnecessary NULL ptr checks from do_path_lookup | Date | Thu, 26 Jul 2012 07:21:05 -0400 |
| |
As best I can tell, whenever retval == 0, nd->path.dentry and nd->inode are also non-NULL. Eliminate those checks and the superfluous audit_context check.
Signed-off-by: Eric Paris <eparis@redhat.com> Signed-off-by: Jeff Layton <jlayton@redhat.com> --- fs/namei.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c index 0b951d4..f252f36 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1856,12 +1856,8 @@ static int do_path_lookup(int dfd, const char *name, if (unlikely(retval == -ESTALE)) retval = path_lookupat(dfd, name, flags | LOOKUP_REVAL, nd); - if (likely(!retval)) { - if (unlikely(!audit_dummy_context())) { - if (nd->path.dentry && nd->inode) - audit_inode(name, nd->path.dentry); - } - } + if (likely(!retval)) + audit_inode(name, nd->path.dentry); return retval; } -- 1.7.11.2
| |