lkml.org 
[lkml]   [2012]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V3 0/4] [SCSI] ufs: Adds glue drivers to ufshcd
On Thu, Jul 26, 2012 at 2:12 PM, Vinayak Holikatti
<vinholikatti@gmail.com> wrote:
> This patch set adds following features
> - Seggregate PCI specific code in ufshcd.c
> - Adds PCI glue driver ufshcd-pci.c and ufshcd.c become core module
> - Adds Platform glue driver ufshcd-pltfrm.c
> - Update correct transfer size in Command UPIU
>
> Vinayak Holikatti (4):
> [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code
> [SCSI] drivers/scsi/ufs: Separate PCI code into glue driver
> [SCSI] ufs: Add Platform glue driver for ufshcd
> [SCSI] ufs: Correct the expected data transfer size
>
> drivers/scsi/ufs/Kconfig | 37 +++-
> drivers/scsi/ufs/Makefile | 2 +
> drivers/scsi/ufs/ufshcd-pci.c | 228 ++++++++++++++++++++
> drivers/scsi/ufs/ufshcd-pltfrm.c | 222 ++++++++++++++++++++
> drivers/scsi/ufs/ufshcd.c | 422 ++++++--------------------------------
> drivers/scsi/ufs/ufshcd.h | 206 +++++++++++++++++++
> drivers/scsi/ufs/ufshcd_common.h | 53 +++++
> 7 files changed, 813 insertions(+), 357 deletions(-)

Two minor observations..
1) If both pci and platform have to do the exact same thing in their
_suspend() and _resume() routines, perhaps there is scope for making
them as common (the steps outlined in them should be done in core
ufshcd) ?

2) Need to include ufshcd_common.h in ufshcd.c so that the prototypes
are supplied for the exported functions.


\
 
 \ /
  Last update: 2012-07-26 13:41    [W:0.091 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site