[lkml]   [2012]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch 2/7] procfs: Convert /proc/pid/fdinfo/ handling routines to seq-file
On Thu, Jul 26, 2012 at 02:43:02PM +0400, Pavel Emelyanov wrote:
> On 07/25/2012 01:47 PM, Cyrill Gorcunov wrote:
> > This patch converts /proc/pid/fdinfo/ handling routines to seq-file which
> > is needed to extend seq operations and plug in auxiliary fdinfo provides
> > from subsystems like eventfd/eventpoll/fsnotify.
> >
> > Note the proc_fd_link no longer call for proc_fd_info, simply because
> > proc_fd_info is converted to seq_fdinfo_open (which is seq-file open()
> > prototype), moreover in further patches I need to provide two seq_fdinfo_open
> > variants -- one with CONFIG_CHECKPOINT_RESTORE and one without this
> > symbol. All in one -- this will look more messy then.
> This is something I'm really not happy with :( After the set applied we will
> have one former proc_fd_info being splitted into 3 (three!) functions doing
> the same (with flavors).
> For me it's better to fix this, otherwise conversion to seq-file looks OK.

OK, thanks for review! I'll try to fix it up.


 \ /
  Last update: 2012-07-26 13:21    [W:0.069 / U:5.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site