Messages in this thread | | | Date | Thu, 26 Jul 2012 03:06:59 -0700 (PDT) | Subject | Re: [PATCH] bcma: fix regression in pmu workaround reg masks | From | David Miller <> |
| |
From: Hauke Mehrtens <hauke@hauke-m.de> Date: Thu, 26 Jul 2012 11:15:51 +0200
> This fixes a regression introduced in: > commit b9562545ef0b13c0440ccd8d6dd4111fb77cb17a > Author: Hauke Mehrtens <hauke@hauke-m.de> > Date: Sat Jun 30 01:44:41 2012 +0200 > > bcma: complete workaround for BCMA43224 and BCM4313 > > The regression broke reading of the sprom from the chip and seamed to > cause a change of the pci id on a BCMA43224 device so that it is > rejected by brcmsmac. If this problem occurred, after applying this > patch, a cold boot is needed to make the device work again. > > In the original patch the workaround set the intended bits in the chip > common core chip control registers, but the patch also unset all the > other bits in that register, because of a wrong mask. The original > patch was based on code from brcmsmac and there was an additional > inversing of the mask in the code setting these regs which was missing > here. Now the regs are set like brcmsmac did it before. > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > Reported-by: Linus Torvalds <torvalds@linux-foundation.org> > Tested-by: Seth Forshee <seth.forshee@canonical.com>
Acked-by: David S. Miller <davem@davemloft.net>
| |