Messages in this thread | | | Date | Wed, 25 Jul 2012 17:17:06 -0700 (PDT) | Subject | Re: [PATCH] dynamic_debug: Restore dev_dbg/netdev_dbg functionality, reduce stack use | From | David Miller <> |
| |
From: Joe Perches <joe@perches.com> Date: Wed, 25 Jul 2012 17:10:00 -0700
> commit c4e00daaa9 ("driver-core: extend dev_printk() to pass structured data") > changed __dev_printk and broke dynamic-debug's ability to control the > dynamic prefix of dev_dbg(dev,..). > > dynamic_emit_prefix() adds "[tid] module:func:line:" to the output and > those additions got lost. > > In addition, the current dynamic debug code uses up to 3 recursion > levels via %pV. This can consume quite a bit of stack. Directly > call printk_emit to reduce the recursion by one depth. > > These changes include: > > o Remove KERN_DEBUG from dynamic_emit_prefix > o Create and use function create_syslog_header to format the syslog > header for printk_emit uses. > o Call create_syslog_header and neaten __dev_printk > o Call create_syslog_header and printk_emit from dynamic_dev_dbg > o Call create_syslog_header and printk_emit from dynamic_netdev_dbg > o Make __dev_printk and __netdev_printk static not global > o Remove include header declarations of __dev_printk and __netdev_printk > o Remove now unused EXPORT_SYMBOL()s of __dev_printk and __netdev_printk > o Whitespace neatening > > Signed-off-by: Joe Perches <joe@perches.com>
For networking parts:
Acked-by: David S. Miller <davem@davemloft.net>
| |